magdev/php-qml
1
Fork 0
Code Issues Pull Requests Actions Releases 4 Activity
Files
dev
php-qml/framework/php/phpstan.neon.dist

17 lines
481 B
Plaintext
Raw Permalink Normal View History

Phase 1 sub-commit 7: CI quality job PHPStan (level 6 + symfony extension) and PHP CS Fixer (Symfony + PHP83Migration ruleset) configs at framework/php/. composer.json exposes phpstan / cs:check / cs:fix / phpunit / quality scripts. PHPStan-clean across the bundle; cs:check is happy after auto-fix applied @Symfony idioms (yoda, leading-backslash JSON_*, blank-line before return). Test mocks consolidated into a HubSpy helper to keep PHPStan happy about by-ref captures. Skeleton's Makefile target `quality` chains `composer quality` (in framework/php/) with cmake's all_qmllint target. Local run is green — 11 tests / 32 assertions, no PHPStan errors, cs-fixer clean, qmllint emits advisory warnings only. Layout fix in skeleton's Main.qml: status-dot Rectangles inside RowLayout now use Layout.preferredWidth/Height instead of width/height to satisfy Quick.layout-positioning checks. .gitea/workflows/ci.yml replaces the placeholder with a real `quality` job: setup-php, composer install (cached), the four PHP checks, Qt 6 via install-qt-action (cached), QML module build, qmllint via the all_qmllint CMake target. Workflow exists from this commit onward even if a runner isn't provisioned yet. bridge:doctor lost the Publisher dependency since it was only used as a "service is wired" marker — the command being injectable already proves that. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-02 02:15:06 +02:00
includes:
- vendor/phpstan/phpstan-symfony/extension.neon
Phase 2 sub-commit 2: ModelPublisher + #[BridgeResource] + Doctrine listener Bundle gains the model layer that bridges Doctrine entities to Mercure without per-resource glue. Three new pieces: - `#[BridgeResource(name: ?string)]` attribute marks an entity as a reactive bridge model. Topic name defaults to the lowercased class basename and can be overridden per resource. - `ModelPublisher` translates entity changes into PLAN.md §4 envelopes ({op, id, data, version, ?correlationKey}) and dual-publishes them on `app://model/{name}` (collection topic) and `app://model/{name}/{id}` (entity topic). Entity normalisation goes through Symfony's Serializer (ObjectNormalizer + DateTime + BackedEnum) for predictable JSON. The envelope `version` field is a per-process monotonic counter — fine for single-instance dev mode; production should back this with a Postgres SEQUENCE or equivalent (noted for Phase 4). - `DoctrineBridgeListener` registers `postPersist`/`postUpdate`/ `postRemove` via `#[AsDoctrineListener]` and routes events through ModelPublisher. Entities without `#[BridgeResource]` are silently skipped. Plus the correlation-key plumbing the §5 Update Semantics layer needs: - `CorrelationContext` is a per-request holder for the originating request's `Idempotency-Key`. - `CorrelationKeyListener` reads the header on `KernelEvents::REQUEST` and clears the context on `KernelEvents::TERMINATE` (worker mode hygiene). CLI mutations see no key, which is correct. Bundle composer.json picks up `doctrine/dbal`, `doctrine/orm`, `doctrine/doctrine-bundle`, `symfony/serializer`, `symfony/property-*`, `symfony/uid`. PHPStan extension `phpstan-doctrine` added so the listener's event-args types resolve. Skeleton's framework.yaml enables `serializer` and `property_info`. Tests: 5 new for ModelPublisher (dual publish, correlation echo, delete op omits data, untagged entities ignored, version increments). Total: 16 tests, 45 assertions, PHPStan clean, cs-fixer clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-02 02:32:51 +02:00
- vendor/phpstan/phpstan-doctrine/extension.neon
Phase 1 sub-commit 7: CI quality job PHPStan (level 6 + symfony extension) and PHP CS Fixer (Symfony + PHP83Migration ruleset) configs at framework/php/. composer.json exposes phpstan / cs:check / cs:fix / phpunit / quality scripts. PHPStan-clean across the bundle; cs:check is happy after auto-fix applied @Symfony idioms (yoda, leading-backslash JSON_*, blank-line before return). Test mocks consolidated into a HubSpy helper to keep PHPStan happy about by-ref captures. Skeleton's Makefile target `quality` chains `composer quality` (in framework/php/) with cmake's all_qmllint target. Local run is green — 11 tests / 32 assertions, no PHPStan errors, cs-fixer clean, qmllint emits advisory warnings only. Layout fix in skeleton's Main.qml: status-dot Rectangles inside RowLayout now use Layout.preferredWidth/Height instead of width/height to satisfy Quick.layout-positioning checks. .gitea/workflows/ci.yml replaces the placeholder with a real `quality` job: setup-php, composer install (cached), the four PHP checks, Qt 6 via install-qt-action (cached), QML module build, qmllint via the all_qmllint CMake target. Workflow exists from this commit onward even if a runner isn't provisioned yet. bridge:doctor lost the Publisher dependency since it was only used as a "service is wired" marker — the command being injectable already proves that. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-02 02:15:06 +02:00
parameters:
level: 6
paths:
- src
- tests
excludePaths:
- vendor/*
Phase 2 sub-commit 4: make:bridge:resource maker Bundle picks up symfony/maker-bundle as require-dev. New BridgeResourceMaker under PhpQml\Bridge\Maker generates three files for a named resource: - src/Entity/<Name>.php — Doctrine entity with #[BridgeResource] and a UUIDv7 id by default. --int-id flips to auto-incrementing int IDs. - src/Controller/<Name>Controller.php — CRUD on /api/{plural} (list, create, update, delete) with serializer- normalised JSON responses. - {qml_path}/<Name>List.qml — starter ListView wrapped around a ReactiveListModel bound to the right topic and source URL. The Doctrine subscriber from sub-commit 2 picks the entity up automatically — no per-resource listener generated. The QML snippet target defaults to '../qml/' (relative to the Symfony project root) and is overridable via the maker's $qmlPath constructor arg. Templates live under src/Maker/templates/ as .tpl.php files using short-echo and alternative-syntax control structures by convention. PHPStan and php-cs-fixer skip them — the maker's Generator binds the template variables at render time. Skeleton picks up MakerBundle as a `dev` bundle and require-dev'd symfony/maker-bundle, so `bin/console make:bridge:resource Todo` works out-of-the-box. Verified: maker runs end-to-end against `Todo` and emits readable, syntactically valid output. composer quality (16 tests, 45 assertions, PHPStan clean, cs-fixer clean) stays green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-02 02:45:42 +02:00
# Maker templates use variables injected by the Generator at
# render time; static analysis can't see the binding.
- src/Maker/templates/*
Phase 3 sub-commit 5: maker-output snapshot test + phase closure framework/php/tests/snapshot/ holds reference output for every shipped maker (resource Todo, command MarkAllDone, window Todo). The run.sh script: - git-archives the skeleton into a temp dir - composer-installs against the bundle's real path - removes the existing maker outputs so the regenerators don't bail - runs the three makers - diffs each generated file against the matching baseline CI / make quality fail on any drift; if a template change is intended, the baselines must be regenerated in the same commit. Wired into: - framework/skeleton/Makefile's `quality` target (local/dev runs) - .gitea/workflows/ci.yml (CI runs after qmllint) Plus a few hardenings discovered while wiring this up: - The resource maker template now injects NormalizerInterface (not SerializerInterface — that interface lacks ::normalize()). All Todo controllers re-rendered to match. - The command maker template emits a $this->em->flush() so the injected EntityManager isn't a property.onlyWritten violation in PHPStan after the user fills in the body. - phpstan.neon and php-cs-fixer's Finder both exclude tests/snapshot so the baselines aren't auto-rewritten or analysed as live code. CI workflow now also installs FrankenPHP, builds the todo example, and runs the bridge-integration test from Phase 3 sub-commit 4. Phase 3 done. Outstanding follow-ups (deferred per spec): the qmltestrunner-driven QML unit tests, make:bridge:event, make:bridge:read-model, ReactiveObject pagination. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-02 16:03:41 +02:00
# Snapshot baselines are reference output, not maintained code.
- tests/snapshot/*
Reference in New Issue Copy Permalink