PHPStan (level 6 + symfony extension) and PHP CS Fixer (Symfony + PHP83Migration ruleset) configs at framework/php/. composer.json exposes phpstan / cs:check / cs:fix / phpunit / quality scripts. PHPStan-clean across the bundle; cs:check is happy after auto-fix applied @Symfony idioms (yoda, leading-backslash JSON_*, blank-line before return). Test mocks consolidated into a HubSpy helper to keep PHPStan happy about by-ref captures. Skeleton's Makefile target `quality` chains `composer quality` (in framework/php/) with cmake's all_qmllint target. Local run is green — 11 tests / 32 assertions, no PHPStan errors, cs-fixer clean, qmllint emits advisory warnings only. Layout fix in skeleton's Main.qml: status-dot Rectangles inside RowLayout now use Layout.preferredWidth/Height instead of width/height to satisfy Quick.layout-positioning checks. .gitea/workflows/ci.yml replaces the placeholder with a real `quality` job: setup-php, composer install (cached), the four PHP checks, Qt 6 via install-qt-action (cached), QML module build, qmllint via the all_qmllint CMake target. Workflow exists from this commit onward even if a runner isn't provisioned yet. bridge:doctor lost the Publisher dependency since it was only used as a "service is wired" marker — the command being injectable already proves that. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -5,12 +5,9 @@ declare(strict_types=1);
|
||||
namespace PhpQml\Bridge\Tests\Command;
|
||||
|
||||
use PhpQml\Bridge\Command\BridgeDoctorCommand;
|
||||
use PhpQml\Bridge\Publisher;
|
||||
use PHPUnit\Framework\Attributes\CoversClass;
|
||||
use PHPUnit\Framework\TestCase;
|
||||
use Symfony\Component\Console\Tester\CommandTester;
|
||||
use Symfony\Component\Mercure\HubInterface;
|
||||
use Symfony\Component\Mercure\Update;
|
||||
|
||||
#[CoversClass(BridgeDoctorCommand::class)]
|
||||
final class BridgeDoctorCommandTest extends TestCase
|
||||
@@ -18,11 +15,10 @@ final class BridgeDoctorCommandTest extends TestCase
|
||||
public function testAllPassesWhenEnvIsFullyConfigured(): void
|
||||
{
|
||||
$command = new BridgeDoctorCommand(
|
||||
publisher: $this->makePublisher(),
|
||||
bridgeToken: 'devtoken',
|
||||
mercureUrl: 'http://127.0.0.1:8765/.well-known/mercure',
|
||||
mercurePublisherKey: 'devkey',
|
||||
mercureSubscriberKey: 'devkey',
|
||||
bridgeToken: 'devtoken',
|
||||
mercureUrl: 'http://127.0.0.1:8765/.well-known/mercure',
|
||||
mercurePublisherKey: 'devkey',
|
||||
mercureSubscriberKey: 'devkey',
|
||||
);
|
||||
$tester = new CommandTester($command);
|
||||
|
||||
@@ -37,11 +33,10 @@ final class BridgeDoctorCommandTest extends TestCase
|
||||
public function testFailsAndShowsHintsWhenEnvIsMissing(): void
|
||||
{
|
||||
$command = new BridgeDoctorCommand(
|
||||
publisher: $this->makePublisher(),
|
||||
bridgeToken: '',
|
||||
mercureUrl: '',
|
||||
mercurePublisherKey: '',
|
||||
mercureSubscriberKey: '',
|
||||
bridgeToken: '',
|
||||
mercureUrl: '',
|
||||
mercurePublisherKey: '',
|
||||
mercureSubscriberKey: '',
|
||||
);
|
||||
$tester = new CommandTester($command);
|
||||
|
||||
@@ -58,11 +53,10 @@ final class BridgeDoctorCommandTest extends TestCase
|
||||
public function testConnectOptionFailsClosedAgainstAnUnreachableUrl(): void
|
||||
{
|
||||
$command = new BridgeDoctorCommand(
|
||||
publisher: $this->makePublisher(),
|
||||
bridgeToken: 'devtoken',
|
||||
mercureUrl: 'http://127.0.0.1:8765/.well-known/mercure',
|
||||
mercurePublisherKey: 'devkey',
|
||||
mercureSubscriberKey: 'devkey',
|
||||
bridgeToken: 'devtoken',
|
||||
mercureUrl: 'http://127.0.0.1:8765/.well-known/mercure',
|
||||
mercurePublisherKey: 'devkey',
|
||||
mercureSubscriberKey: 'devkey',
|
||||
);
|
||||
$tester = new CommandTester($command);
|
||||
|
||||
@@ -72,17 +66,4 @@ final class BridgeDoctorCommandTest extends TestCase
|
||||
self::assertSame(1, $exit);
|
||||
self::assertStringContainsString('Backend probe failed', $tester->getDisplay());
|
||||
}
|
||||
|
||||
private function makePublisher(): Publisher
|
||||
{
|
||||
return new Publisher(new class implements HubInterface {
|
||||
public function getUrl(): string { return ''; }
|
||||
public function getPublicUrl(): string { return ''; }
|
||||
public function getProvider(): \Symfony\Component\Mercure\Jwt\TokenProviderInterface
|
||||
{ throw new \LogicException(); }
|
||||
public function getFactory(): ?\Symfony\Component\Mercure\Jwt\TokenFactoryInterface
|
||||
{ return null; }
|
||||
public function publish(Update $update): string { return ''; }
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user