Phase 3 sub-commit 5: maker-output snapshot test + phase closure
framework/php/tests/snapshot/ holds reference output for every shipped
maker (resource Todo, command MarkAllDone, window Todo). The
run.sh script:
- git-archives the skeleton into a temp dir
- composer-installs against the bundle's real path
- removes the existing maker outputs so the regenerators don't bail
- runs the three makers
- diffs each generated file against the matching baseline
CI / make quality fail on any drift; if a template change is intended,
the baselines must be regenerated in the same commit. Wired into:
- framework/skeleton/Makefile's `quality` target (local/dev runs)
- .gitea/workflows/ci.yml (CI runs after qmllint)
Plus a few hardenings discovered while wiring this up:
- The resource maker template now injects NormalizerInterface
(not SerializerInterface — that interface lacks ::normalize()).
All Todo controllers re-rendered to match.
- The command maker template emits a $this->em->flush() so the
injected EntityManager isn't a property.onlyWritten violation
in PHPStan after the user fills in the body.
- phpstan.neon and php-cs-fixer's Finder both exclude tests/snapshot
so the baselines aren't auto-rewritten or analysed as live code.
CI workflow now also installs FrankenPHP, builds the todo example, and
runs the bridge-integration test from Phase 3 sub-commit 4.
Phase 3 done. Outstanding follow-ups (deferred per spec): the
qmltestrunner-driven QML unit tests, make:bridge:event,
make:bridge:read-model, ReactiveObject pagination.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -67,3 +67,22 @@ jobs:
|
||||
- name: qmllint
|
||||
working-directory: framework/skeleton
|
||||
run: cmake --build build/qml --target all_qmllint
|
||||
|
||||
- name: Install FrankenPHP
|
||||
run: |
|
||||
curl -fsSL -o /usr/local/bin/frankenphp \
|
||||
https://github.com/php/frankenphp/releases/download/v1.12.2/frankenphp-linux-x86_64
|
||||
chmod +x /usr/local/bin/frankenphp
|
||||
|
||||
- name: Maker-output snapshot test
|
||||
run: framework/php/tests/snapshot/run.sh
|
||||
|
||||
- name: Build the todo example
|
||||
working-directory: examples/todo
|
||||
run: |
|
||||
make install
|
||||
make build
|
||||
|
||||
- name: Bridge-integration test (HTTP/SSE round-trip + crash-recover)
|
||||
working-directory: examples/todo
|
||||
run: ./tests/integration.sh
|
||||
|
||||
Reference in New Issue
Block a user