Phase 3 sub-commit 5: maker-output snapshot test + phase closure

framework/php/tests/snapshot/ holds reference output for every shipped
maker (resource Todo, command MarkAllDone, window Todo). The
run.sh script:

  - git-archives the skeleton into a temp dir
  - composer-installs against the bundle's real path
  - removes the existing maker outputs so the regenerators don't bail
  - runs the three makers
  - diffs each generated file against the matching baseline

CI / make quality fail on any drift; if a template change is intended,
the baselines must be regenerated in the same commit. Wired into:

  - framework/skeleton/Makefile's `quality` target (local/dev runs)
  - .gitea/workflows/ci.yml (CI runs after qmllint)

Plus a few hardenings discovered while wiring this up:

  - The resource maker template now injects NormalizerInterface
    (not SerializerInterface — that interface lacks ::normalize()).
    All Todo controllers re-rendered to match.
  - The command maker template emits a $this->em->flush() so the
    injected EntityManager isn't a property.onlyWritten violation
    in PHPStan after the user fills in the body.
  - phpstan.neon and php-cs-fixer's Finder both exclude tests/snapshot
    so the baselines aren't auto-rewritten or analysed as live code.

CI workflow now also installs FrankenPHP, builds the todo example, and
runs the bridge-integration test from Phase 3 sub-commit 4.

Phase 3 done. Outstanding follow-ups (deferred per spec): the
qmltestrunner-driven QML unit tests, make:bridge:event,
make:bridge:read-model, ReactiveObject pagination.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-05-02 16:03:41 +02:00
parent 1288a960d4
commit adc0cdc11d
15 changed files with 366 additions and 20 deletions

View File

@@ -4,7 +4,12 @@ $finder = (new PhpCsFixer\Finder())
->in([__DIR__ . '/src', __DIR__ . '/tests'])
// Maker templates use short-echo syntax and alternative-syntax control
// structures by design — cs-fixer's @Symfony rules would mangle them.
->notPath('Maker/templates');
->notPath('Maker/templates')
// Maker-output snapshot baselines are the makers' exact output and
// must not be auto-rewritten; if they need updating, the maker
// template changes and the snapshot is regenerated explicitly.
// (notPath is relative to each `in()` dir, not the project root.)
->notPath('snapshot');
return (new PhpCsFixer\Config())
->setRiskyAllowed(true)