Phase 3 sub-commit 5: maker-output snapshot test + phase closure

framework/php/tests/snapshot/ holds reference output for every shipped
maker (resource Todo, command MarkAllDone, window Todo). The
run.sh script:

  - git-archives the skeleton into a temp dir
  - composer-installs against the bundle's real path
  - removes the existing maker outputs so the regenerators don't bail
  - runs the three makers
  - diffs each generated file against the matching baseline

CI / make quality fail on any drift; if a template change is intended,
the baselines must be regenerated in the same commit. Wired into:

  - framework/skeleton/Makefile's `quality` target (local/dev runs)
  - .gitea/workflows/ci.yml (CI runs after qmllint)

Plus a few hardenings discovered while wiring this up:

  - The resource maker template now injects NormalizerInterface
    (not SerializerInterface — that interface lacks ::normalize()).
    All Todo controllers re-rendered to match.
  - The command maker template emits a $this->em->flush() so the
    injected EntityManager isn't a property.onlyWritten violation
    in PHPStan after the user fills in the body.
  - phpstan.neon and php-cs-fixer's Finder both exclude tests/snapshot
    so the baselines aren't auto-rewritten or analysed as live code.

CI workflow now also installs FrankenPHP, builds the todo example, and
runs the bridge-integration test from Phase 3 sub-commit 4.

Phase 3 done. Outstanding follow-ups (deferred per spec): the
qmltestrunner-driven QML unit tests, make:bridge:event,
make:bridge:read-model, ReactiveObject pagination.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-05-02 16:03:41 +02:00
parent 1288a960d4
commit adc0cdc11d
15 changed files with 366 additions and 20 deletions

View File

@@ -10,7 +10,7 @@ use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Attribute\Route;
use Symfony\Component\Serializer\SerializerInterface;
use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
/**
* Auto-generated CRUD controller for the Todo bridge resource.
@@ -21,7 +21,7 @@ final class TodoController
{
public function __construct(
private readonly EntityManagerInterface $em,
private readonly SerializerInterface $serializer,
private readonly NormalizerInterface $normalizer,
) {
}
@@ -30,7 +30,7 @@ final class TodoController
{
$items = $this->em->getRepository(Todo::class)->findAll();
return new JsonResponse($this->serializer->normalize($items, 'json'));
return new JsonResponse($this->normalizer->normalize($items, 'json'));
}
#[Route('', name: 'todo_create', methods: ['POST'])]
@@ -51,7 +51,7 @@ final class TodoController
$this->em->flush();
return new JsonResponse(
$this->serializer->normalize($entity, 'json'),
$this->normalizer->normalize($entity, 'json'),
Response::HTTP_CREATED,
);
}
@@ -81,7 +81,7 @@ final class TodoController
$this->em->flush();
return new JsonResponse($this->serializer->normalize($entity, 'json'));
return new JsonResponse($this->normalizer->normalize($entity, 'json'));
}
#[Route('/{id}', name: 'todo_delete', methods: ['DELETE'])]