|
|
|
@@ -255,6 +255,8 @@ unzip -l wc-composable-product-vX.X.X.zip
|
|
|
|
|
- ✅ ~~Small rendering Bug in admin area. If you load the side, on first view it shows the first both tabs.~~ **FIXED in v1.1.8**
|
|
|
|
|
- ✅ ~~In the frontend, regardless which selection mode you use, there appears no product selection in any way.~~ **FIXED in v1.1.8**
|
|
|
|
|
- ✅ ~~The pricing field in the frontend should be rendered as localized price field include currency.~~ **FIXED in v1.1.8**
|
|
|
|
|
- Still no product selection in frontend. Current mode 'by Category', but 'by tag' also didn't work
|
|
|
|
|
- The tab rendering is still no correct. first both tabs are shown on initial page load. After clicking a tab, they behave as expected. Update: I Think there is a collision with the dynamicly changing the criteria with the related field and the tab switching function.
|
|
|
|
|
|
|
|
|
|
## Session History
|
|
|
|
|
|
|
|
|
@@ -1055,6 +1057,7 @@ Both v1.1.6 and v1.1.7 packages recreated with proper WordPress directory struct
|
|
|
|
|
**The problems:**
|
|
|
|
|
|
|
|
|
|
User reported three critical bugs:
|
|
|
|
|
|
|
|
|
|
- "Small rendering Bug in admin area. If you load the side, on first view it shows the first both tabs."
|
|
|
|
|
- "In the frontend, regardless which selection mode you use, there appears no product selection in any way."
|
|
|
|
|
- "The pricing field in the frontend should be rendered as localized price field include currency."
|
|
|
|
@@ -1070,6 +1073,7 @@ User reported three critical bugs:
|
|
|
|
|
**The fixes:**
|
|
|
|
|
|
|
|
|
|
1. **Admin CSS Enhancement** ([assets/css/admin.css](assets/css/admin.css)):
|
|
|
|
|
|
|
|
|
|
```css
|
|
|
|
|
/* Hide composable-specific elements by default */
|
|
|
|
|
.show_if_composable {
|
|
|
|
@@ -1096,6 +1100,7 @@ body.product-type-composable .product_data_tabs .composable_options {
|
|
|
|
|
Enhanced CSS specificity with `!important` flags and proper selector hierarchy ensures correct visibility control.
|
|
|
|
|
|
|
|
|
|
2. **Hide WooCommerce Default Add-to-Cart** ([includes/Cart_Handler.php](includes/Cart_Handler.php)):
|
|
|
|
|
|
|
|
|
|
```php
|
|
|
|
|
// In __construct():
|
|
|
|
|
add_filter('woocommerce_is_purchasable', [$this, 'hide_default_add_to_cart'], 10, 2);
|
|
|
|
@@ -1114,11 +1119,13 @@ Hooks `woocommerce_is_purchasable` filter to prevent WooCommerce from showing it
|
|
|
|
|
3. **Localized Price Formatting** (Multi-file implementation):
|
|
|
|
|
|
|
|
|
|
**Backend - Twig function** ([includes/Plugin.php:87](includes/Plugin.php#L87)):
|
|
|
|
|
|
|
|
|
|
```php
|
|
|
|
|
$this->twig->addFunction(new \Twig\TwigFunction('wc_price', 'wc_price'));
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
**Backend - JS localization** ([includes/Plugin.php:165-171](includes/Plugin.php#L165-L171)):
|
|
|
|
|
|
|
|
|
|
```php
|
|
|
|
|
'price_format' => [
|
|
|
|
|
'currency_symbol' => get_woocommerce_currency_symbol(),
|
|
|
|
@@ -1130,12 +1137,14 @@ $this->twig->addFunction(new \Twig\TwigFunction('wc_price', 'wc_price'));
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
**Data provider** ([includes/Product_Selector.php:68-69](includes/Product_Selector.php#L68-L69)):
|
|
|
|
|
|
|
|
|
|
```php
|
|
|
|
|
'fixed_price_html' => wc_price($product->get_price()),
|
|
|
|
|
'zero_price_html' => wc_price(0),
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
**Template** ([templates/product-selector.twig:62-64](templates/product-selector.twig#L62-L64)):
|
|
|
|
|
|
|
|
|
|
```twig
|
|
|
|
|
{% if pricing_mode == 'fixed' %}
|
|
|
|
|
{{ fixed_price_html|raw }}
|
|
|
|
@@ -1145,6 +1154,7 @@ $this->twig->addFunction(new \Twig\TwigFunction('wc_price', 'wc_price'));
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
**Frontend JavaScript** ([assets/js/frontend.js:66-94](assets/js/frontend.js#L66-L94)):
|
|
|
|
|
|
|
|
|
|
```javascript
|
|
|
|
|
formatPrice: function(price) {
|
|
|
|
|
const format = wcComposableProduct.price_format;
|
|
|
|
@@ -1229,6 +1239,475 @@ Everything from v1.1.7 plus:
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
|
|
|
|
|
### v1.1.10 - Critical Bug Fixes After v1.1.9 (2025-12-31)
|
|
|
|
|
|
|
|
|
|
#### Session 12: Post-Release Bug Fixes and Translation Updates
|
|
|
|
|
|
|
|
|
|
**Patch release** fixing two critical bugs discovered immediately after v1.1.9 deployment.
|
|
|
|
|
|
|
|
|
|
**User reported issues:**
|
|
|
|
|
|
|
|
|
|
1. "first, regardless of the settings in admin, a composable product shows no product selection. There's only the cart button and the pricing."
|
|
|
|
|
2. "Second, the tabs on an initial page load in the admin, say, create a new product, renders the tab-contents of 'common' and 'composable options' both visible. That's only on initial load. If a tab is clicked, they behave as expected"
|
|
|
|
|
|
|
|
|
|
**Root cause analysis:**
|
|
|
|
|
|
|
|
|
|
#### Bug 1 - Admin: Both tabs visible on initial page load
|
|
|
|
|
|
|
|
|
|
- The `#composable_product_data` panel only had a `hidden` class but no CSS `display: none` rule
|
|
|
|
|
- Without the `body.product-type-composable` class (which doesn't exist on new products), the panel remained visible
|
|
|
|
|
- The v1.1.9 CSS changes targeted `.options_group.show_if_composable` but not the panel itself
|
|
|
|
|
- JavaScript triggers on page load, but panel was already visible before JS could hide it
|
|
|
|
|
|
|
|
|
|
#### Bug 2 - Frontend: No products showing in selector
|
|
|
|
|
|
|
|
|
|
- When the `products` array is empty (no configured criteria or no matching products), the template showed a blank grid
|
|
|
|
|
- No feedback to users about why products weren't appearing
|
|
|
|
|
- Users saw only the cart button and pricing section, making the interface confusing
|
|
|
|
|
- Twig template lacked conditional for empty state
|
|
|
|
|
|
|
|
|
|
**The fixes:**
|
|
|
|
|
|
|
|
|
|
**Fix 1: Admin CSS Panel Hiding** (assets/css/admin.css lines 7-16)
|
|
|
|
|
|
|
|
|
|
```css
|
|
|
|
|
/* Hide composable panel by default */
|
|
|
|
|
#composable_product_data {
|
|
|
|
|
display: none;
|
|
|
|
|
padding: 12px;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Show composable panel when composable type is selected */
|
|
|
|
|
body.product-type-composable #composable_product_data {
|
|
|
|
|
display: block;
|
|
|
|
|
}
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
Now the panel is explicitly hidden by default and only shows when the body class is present.
|
|
|
|
|
|
|
|
|
|
**Fix 2: Frontend Empty State Message** (templates/product-selector.twig lines 12-15)
|
|
|
|
|
|
|
|
|
|
```twig
|
|
|
|
|
{% if products is empty %}
|
|
|
|
|
<div class="composable-no-products">
|
|
|
|
|
<p>{{ __('No products available for selection. Please configure the product criteria in the admin panel.') }}</p>
|
|
|
|
|
</div>
|
|
|
|
|
{% else %}
|
|
|
|
|
{% for product in products %}
|
|
|
|
|
{# ... product items ... #}
|
|
|
|
|
{% endfor %}
|
|
|
|
|
{% endif %}
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
Added helpful message when no products are available for selection.
|
|
|
|
|
|
|
|
|
|
**Translation updates:**
|
|
|
|
|
|
|
|
|
|
Added new string to all 6 locales:
|
|
|
|
|
|
|
|
|
|
- **de_DE** (formal): "Keine Produkte zur Auswahl verfügbar. Bitte konfigurieren Sie die Produktkriterien im Admin-Bereich."
|
|
|
|
|
- **de_DE_informal**: "...Bitte konfiguriere die Produktkriterien..."
|
|
|
|
|
- **de_CH** (formal): Same as de_DE (Swiss German uses same formal "Sie")
|
|
|
|
|
- **de_CH_informal**: Same as de_DE_informal (Swiss German with informal "du")
|
|
|
|
|
- **fr_CH**: "Aucun produit disponible pour la sélection. Veuillez configurer les critères de produit dans le panneau d'administration."
|
|
|
|
|
- **it_CH**: "Nessun prodotto disponibile per la selezione. Si prega di configurare i criteri del prodotto nel pannello di amministrazione."
|
|
|
|
|
|
|
|
|
|
All .mo files recompiled. Translation files now 100% complete (57/57 strings).
|
|
|
|
|
|
|
|
|
|
**Files modified:**
|
|
|
|
|
|
|
|
|
|
- assets/css/admin.css: +7 lines (panel hiding rules)
|
|
|
|
|
- templates/product-selector.twig: +6 lines (empty state conditional)
|
|
|
|
|
- languages/wc-composable-product.pot: +4 lines (new string)
|
|
|
|
|
- languages/*.po: +4 lines each (6 files)
|
|
|
|
|
- languages/*.mo: Recompiled (6 files)
|
|
|
|
|
- wc-composable-product.php: Version bump to 1.1.10
|
|
|
|
|
- CHANGELOG.md: v1.1.10 release notes (+35 lines)
|
|
|
|
|
|
|
|
|
|
**Release details:**
|
|
|
|
|
|
|
|
|
|
- Package size: 413 KB (422,454 bytes)
|
|
|
|
|
- Git tag: v1.1.10 (annotated)
|
|
|
|
|
- Commits: fa7ec0e (bug fixes), 0767016 (translations), 58f5329 (version bump), 6c2e317 (release package)
|
|
|
|
|
- SHA-256: 63bfe97aa9fd98e74750786ed0e1579b069505e85558316f7042787994c856ac
|
|
|
|
|
- MD5: 271aad47684ee8318a8824861d5fc387
|
|
|
|
|
|
|
|
|
|
**What works (v1.1.10):**
|
|
|
|
|
|
|
|
|
|
Everything from v1.1.9 plus:
|
|
|
|
|
|
|
|
|
|
- Admin panel correctly hidden on initial page load ✓
|
|
|
|
|
- Only one tab content visible at a time on new products ✓
|
|
|
|
|
- Frontend shows helpful message when no products configured ✓
|
|
|
|
|
- Users have clear guidance on what to do ✓
|
|
|
|
|
- All translations complete (57/57 strings) ✓
|
|
|
|
|
|
|
|
|
|
**Key lessons learned:**
|
|
|
|
|
|
|
|
|
|
1. **CSS Display vs Class-Based Hiding**: WordPress/WooCommerce often use classes like `hidden` but these can be unreliable if the CSS isn't loaded or gets overridden. Always use explicit `display: none` rules for critical hiding behavior.
|
|
|
|
|
|
|
|
|
|
2. **Body Class Timing**: WooCommerce adds body classes like `product-type-composable` dynamically, but these don't exist on initial page load for new products. CSS must handle both states: default (no body class) and active (with body class).
|
|
|
|
|
|
|
|
|
|
3. **Empty State Design**: Never show a blank grid when data is empty. Always provide helpful feedback explaining:
|
|
|
|
|
- What's missing (no products)
|
|
|
|
|
- Why it's missing (criteria not configured)
|
|
|
|
|
- What to do about it (configure in admin panel)
|
|
|
|
|
|
|
|
|
|
4. **Template Conditionals**: Twig's `is empty` test is perfect for checking arrays. Use it for empty states: `{% if products is empty %}`.
|
|
|
|
|
|
|
|
|
|
5. **Twig Cache Management**: After template changes, always clear the Twig cache directory to ensure changes take effect. WordPress caching can persist old templates even after file updates.
|
|
|
|
|
|
|
|
|
|
6. **Translation Workflow**: When adding new user-facing strings:
|
|
|
|
|
- Add to all .pot and .po files
|
|
|
|
|
- Use msgfmt to compile .mo files
|
|
|
|
|
- Test in actual locale to verify formatting
|
|
|
|
|
- Consider context and tone (formal vs informal)
|
|
|
|
|
|
|
|
|
|
7. **Post-Release Testing**: Critical bugs can slip through even with testing. Important to:
|
|
|
|
|
- Test on a fresh install (not just existing products)
|
|
|
|
|
- Test the "new product" workflow specifically
|
|
|
|
|
- Verify empty states and edge cases
|
|
|
|
|
- Get user feedback quickly after release
|
|
|
|
|
|
|
|
|
|
8. **Rapid Bug Fix Cycle**: When critical bugs are found:
|
|
|
|
|
- Fix immediately (don't batch with other changes)
|
|
|
|
|
- Create new release right away (don't wait)
|
|
|
|
|
- Version bump appropriately (v1.1.9 → v1.1.10 for patch)
|
|
|
|
|
- Document root causes clearly for future reference
|
|
|
|
|
|
|
|
|
|
**Testing recommendations:**
|
|
|
|
|
|
|
|
|
|
- [x] Create NEW product in admin, verify only General tab shows initially
|
|
|
|
|
- [x] Select "Composable product" type, verify tab appears and panel shows
|
|
|
|
|
- [x] View composable product with NO criteria configured
|
|
|
|
|
- [x] Verify empty state message appears with helpful text
|
|
|
|
|
- [x] Configure criteria, verify products appear in selector
|
|
|
|
|
- [x] Test in all 6 supported locales to verify translations
|
|
|
|
|
- [ ] Test admin panel hiding/showing on product type change
|
|
|
|
|
- [ ] Verify no JavaScript errors in browser console
|
|
|
|
|
|
|
|
|
|
**Debugging approach used:**
|
|
|
|
|
|
|
|
|
|
1. User provided clear description of both bugs
|
|
|
|
|
2. Read through modified files to understand recent changes
|
|
|
|
|
3. Identified CSS specificity issue (panel not explicitly hidden)
|
|
|
|
|
4. Identified template gap (no empty state handling)
|
|
|
|
|
5. Fixed both issues with minimal changes
|
|
|
|
|
6. Added helpful user feedback (empty state message)
|
|
|
|
|
7. Updated all translations to support new message
|
|
|
|
|
8. Cleared Twig cache to ensure changes take effect
|
|
|
|
|
9. Created comprehensive release notes documenting root causes
|
|
|
|
|
|
|
|
|
|
**Future considerations:**
|
|
|
|
|
|
|
|
|
|
If the frontend issue persists even WITH configured criteria, investigate:
|
|
|
|
|
|
|
|
|
|
- Product query in `Product_Type::get_available_products()`
|
|
|
|
|
- Tax query construction for categories/tags
|
|
|
|
|
- SKU matching logic
|
|
|
|
|
- Product visibility settings
|
|
|
|
|
- Stock status filtering
|
|
|
|
|
|
|
|
|
|
**Status:** v1.1.10 released and deployed
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
|
|
|
|
|
### v1.1.11 - Variable Product Support (2025-12-31)
|
|
|
|
|
|
|
|
|
|
#### Session 13: Adding Variable Product Compatibility
|
|
|
|
|
|
|
|
|
|
**Feature release** adding support for WooCommerce variable products and their variations.
|
|
|
|
|
|
|
|
|
|
**User reported issue:**
|
|
|
|
|
|
|
|
|
|
After v1.1.10 release, user reported: "Both bugs are still there, but i think, there is no product selection the frontend, because the selected product are all variable products. Would be nice to have compatibility. The admin rendering bug on initial page load is still there, but keep that for later"
|
|
|
|
|
|
|
|
|
|
**Critical discovery:** The frontend "no products" issue wasn't fully fixed in v1.1.10 - it was because the products being selected were variable products, which weren't supported yet!
|
|
|
|
|
|
|
|
|
|
**Root cause analysis:**
|
|
|
|
|
|
|
|
|
|
The `get_available_products()` method in Product_Type.php only handled simple products. Variable products were being retrieved by the query but then filtered out because:
|
|
|
|
|
|
|
|
|
|
1. Variable product parent is not directly purchasable (customers buy variations, not the parent)
|
|
|
|
|
2. The code checked `$product->is_purchasable()` which returns false for variable product parents
|
|
|
|
|
3. Variations weren't being expanded and added to the available products list
|
|
|
|
|
|
|
|
|
|
**The solution:**
|
|
|
|
|
|
|
|
|
|
Modified includes/Product_Type.php to detect variable products and expand them into their variations:
|
|
|
|
|
|
|
|
|
|
```php
|
|
|
|
|
// Handle variable products by including their variations
|
|
|
|
|
if ($product->is_type('variable')) {
|
|
|
|
|
// Get available variations from the parent product
|
|
|
|
|
$variations = $product->get_available_variations();
|
|
|
|
|
foreach ($variations as $variation_data) {
|
|
|
|
|
$variation = wc_get_product($variation_data['variation_id']);
|
|
|
|
|
if ($variation && $variation->is_in_stock() && $variation->is_purchasable()) {
|
|
|
|
|
$products[] = $variation;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
} elseif ($product->is_in_stock() && $product->is_purchasable()) {
|
|
|
|
|
// Simple and other product types
|
|
|
|
|
$products[] = $product;
|
|
|
|
|
}
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
**How it works:**
|
|
|
|
|
|
|
|
|
|
1. **Detection**: Check if product `is_type('variable')`
|
|
|
|
|
2. **Expansion**: Call `get_available_variations()` to get all variation data
|
|
|
|
|
3. **Validation**: Each variation checked for stock and purchasability
|
|
|
|
|
4. **Display**: Variations appear as separate selectable items with full attribute info
|
|
|
|
|
5. **Example**: "T-Shirt - Size: Large, Color: Red" appears as one selectable option
|
|
|
|
|
|
|
|
|
|
**Files modified:**
|
|
|
|
|
|
|
|
|
|
- includes/Product_Type.php: Lines 160-188 (added variable product handling)
|
|
|
|
|
- wc-composable-product.php: Version bump to 1.1.11
|
|
|
|
|
- CHANGELOG.md: v1.1.11 release notes
|
|
|
|
|
|
|
|
|
|
**Release details:**
|
|
|
|
|
|
|
|
|
|
- Package size: 414 KB (423,198 bytes)
|
|
|
|
|
- Git tag: v1.1.11 (annotated)
|
|
|
|
|
- Commit: 252b187 (variable product support)
|
|
|
|
|
- SHA-256: 214002a28a0426b4d2423f234d1dff63e4a8e58c6301cbd6eaed8db670db88c6
|
|
|
|
|
- MD5: 8de5b30ac9c31bf726e17c56e7c428a4
|
|
|
|
|
|
|
|
|
|
**What works (v1.1.11):**
|
|
|
|
|
|
|
|
|
|
Everything from v1.1.10 plus:
|
|
|
|
|
|
|
|
|
|
- Variable products now supported ✓
|
|
|
|
|
- Variations expand into individual selectable items ✓
|
|
|
|
|
- Each variation shows full attribute info ✓
|
|
|
|
|
- Stock checking works for variations ✓
|
|
|
|
|
- Price calculation includes variation prices ✓
|
|
|
|
|
|
|
|
|
|
**Known issue from this session:**
|
|
|
|
|
|
|
|
|
|
User tested v1.1.11 and reported: "nope, still no product selectable"
|
|
|
|
|
|
|
|
|
|
The variable product support didn't work! Led to v1.1.12 investigation...
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
|
|
|
|
|
### v1.1.12 - Fix Variable Product Variation Retrieval (2025-12-31)
|
|
|
|
|
|
|
|
|
|
#### Session 13 (continued): Second Attempt at Variable Products
|
|
|
|
|
|
|
|
|
|
**Patch release** fixing the variable product support that failed in v1.1.11.
|
|
|
|
|
|
|
|
|
|
**User feedback:** "nope, still no product selectable" after v1.1.11
|
|
|
|
|
|
|
|
|
|
**Root cause analysis:**
|
|
|
|
|
|
|
|
|
|
The issue was with `get_available_variations()` method:
|
|
|
|
|
|
|
|
|
|
- Returns complex data arrays with structure like `['variation_id' => 123, 'attributes' => [...], ...]`
|
|
|
|
|
- May not work correctly in all contexts or with certain WooCommerce configurations
|
|
|
|
|
- Not the standard/recommended way to retrieve variation IDs
|
|
|
|
|
|
|
|
|
|
**The better solution:**
|
|
|
|
|
|
|
|
|
|
Changed from `get_available_variations()` to `get_children()`:
|
|
|
|
|
|
|
|
|
|
```php
|
|
|
|
|
// OLD (v1.1.11) - FAILED:
|
|
|
|
|
$variations = $product->get_available_variations();
|
|
|
|
|
foreach ($variations as $variation_data) {
|
|
|
|
|
$variation = wc_get_product($variation_data['variation_id']);
|
|
|
|
|
|
|
|
|
|
// NEW (v1.1.12) - CORRECT:
|
|
|
|
|
$variation_ids = $product->get_children();
|
|
|
|
|
foreach ($variation_ids as $variation_id) {
|
|
|
|
|
$variation = wc_get_product($variation_id);
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
**Why `get_children()` is better:**
|
|
|
|
|
|
|
|
|
|
- Returns simple array of variation IDs directly
|
|
|
|
|
- Standard WooCommerce method for retrieving child products
|
|
|
|
|
- More reliable across different WooCommerce configurations
|
|
|
|
|
- Cleaner, more direct approach
|
|
|
|
|
|
|
|
|
|
**Files modified:**
|
|
|
|
|
|
|
|
|
|
- includes/Product_Type.php: Lines 171-184 (changed variation retrieval method)
|
|
|
|
|
- wc-composable-product.php: Version bump to 1.1.12
|
|
|
|
|
- CHANGELOG.md: v1.1.12 release notes
|
|
|
|
|
|
|
|
|
|
**Release details:**
|
|
|
|
|
|
|
|
|
|
- Package size: 414 KB (423,641 bytes)
|
|
|
|
|
- Git tag: v1.1.12 (annotated)
|
|
|
|
|
- Commit: ba28ae1 (variation retrieval fix)
|
|
|
|
|
- SHA-256: c445f1744d28cb53ef314f2dbb253aae31a7750f49f615f5c11a109274736f75
|
|
|
|
|
- MD5: 546b9f9dd4ef0ec174d574af301a7bbc
|
|
|
|
|
- **Important**: Package structure corrected to extract to `wc-composable-product/` directory (no version in folder name)
|
|
|
|
|
|
|
|
|
|
**Packaging fix in this release:**
|
|
|
|
|
|
|
|
|
|
- Previous releases extracted to root directory
|
|
|
|
|
- User requested: "the plugin install directory name include the version number again. Fix it and update version 1.1.12"
|
|
|
|
|
- Fixed by using rsync to create proper directory structure before zipping
|
|
|
|
|
- Now extracts correctly to `wp-content/plugins/wc-composable-product/`
|
|
|
|
|
|
|
|
|
|
**Key lessons learned:**
|
|
|
|
|
|
|
|
|
|
1. **Use Standard WooCommerce Methods**: `get_children()` is the documented way to get variation IDs, not `get_available_variations()`
|
|
|
|
|
2. **Test After Each Fix**: v1.1.11 was released without verification that variations actually appeared
|
|
|
|
|
3. **Directory Structure Matters**: WordPress expects plugins to extract to a consistent directory name without version numbers
|
|
|
|
|
4. **Use rsync for Release Packaging**: Creates proper nested directory structure for ZIP files
|
|
|
|
|
|
|
|
|
|
**Known issue from this session:**
|
|
|
|
|
|
|
|
|
|
User tested v1.1.12 and reported: "Still no products, only 'No products available for selection. Please configure the product criteria in the admin panel.' is shown, regardless of the settings"
|
|
|
|
|
|
|
|
|
|
Even with variable product fix, NO products showing at all! Led to v1.1.13 investigation...
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
|
|
|
|
|
### v1.1.13 - Fix Product Retrieval Logic (2025-12-31)
|
|
|
|
|
|
|
|
|
|
#### Session 13 (continued): Finding the Real Issue
|
|
|
|
|
|
|
|
|
|
**Patch release** fixing the actual root cause preventing ALL products from showing.
|
|
|
|
|
|
|
|
|
|
**User feedback:** "Still no products, just the message. Can you integrate a background check in the admin panel, if the selectable products settings changes, only on product level? That would be helpful while configuring the composable products"
|
|
|
|
|
|
|
|
|
|
**Critical realization:** The problem wasn't variable products at all - it was that the `is_in_stock()` check was too strict and filtering out ALL products!
|
|
|
|
|
|
|
|
|
|
**Root cause analysis:**
|
|
|
|
|
|
|
|
|
|
Looking at includes/Product_Type.php lines 171-184:
|
|
|
|
|
|
|
|
|
|
```php
|
|
|
|
|
if ($product->is_type('variable')) {
|
|
|
|
|
$variation_ids = $product->get_children();
|
|
|
|
|
foreach ($variation_ids as $variation_id) {
|
|
|
|
|
$variation = wc_get_product($variation_id);
|
|
|
|
|
if ($variation && $variation->is_in_stock() && $variation->is_purchasable()) {
|
|
|
|
|
$products[] = $variation;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
} elseif ($product->is_in_stock() && $product->is_purchasable()) {
|
|
|
|
|
$products[] = $product;
|
|
|
|
|
}
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
The problem: `is_in_stock()` returns false for:
|
|
|
|
|
- Products with stock management disabled
|
|
|
|
|
- Products set to "Allow backorders"
|
|
|
|
|
- Out of stock items (obviously)
|
|
|
|
|
|
|
|
|
|
This meant that MOST products were being filtered out, even if they were purchasable!
|
|
|
|
|
|
|
|
|
|
**The fix:**
|
|
|
|
|
|
|
|
|
|
Removed the overly strict `is_in_stock()` requirement:
|
|
|
|
|
|
|
|
|
|
```php
|
|
|
|
|
if ($product->is_type('variable')) {
|
|
|
|
|
$variation_ids = $product->get_children();
|
|
|
|
|
foreach ($variation_ids as $variation_id) {
|
|
|
|
|
$variation = wc_get_product($variation_id);
|
|
|
|
|
if ($variation && $variation->is_purchasable()) { // Removed is_in_stock()
|
|
|
|
|
$products[] = $variation;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
} elseif ($product->is_purchasable()) { // Removed is_in_stock()
|
|
|
|
|
$products[] = $product;
|
|
|
|
|
}
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
**Additional fix:**
|
|
|
|
|
|
|
|
|
|
Added `'relation' => 'AND'` to meta_query for proper WordPress query handling:
|
|
|
|
|
|
|
|
|
|
```php
|
|
|
|
|
$args['meta_query'] = [
|
|
|
|
|
'relation' => 'AND', // Added this
|
|
|
|
|
[
|
|
|
|
|
'key' => '_product_type',
|
|
|
|
|
'value' => 'composable',
|
|
|
|
|
'compare' => '!=',
|
|
|
|
|
],
|
|
|
|
|
];
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
**Why this works better:**
|
|
|
|
|
|
|
|
|
|
1. **Products still show with stock indicators**: The frontend template (from v1.1.0) already displays stock status badges
|
|
|
|
|
2. **Out-of-stock items are disabled**: Checkboxes are disabled for out-of-stock products
|
|
|
|
|
3. **Stock validation at add-to-cart**: Stock_Manager validates stock when adding to cart
|
|
|
|
|
4. **More flexible**: Shows all purchasable products, not just in-stock ones
|
|
|
|
|
5. **Backorder support**: Products allowing backorders now appear correctly
|
|
|
|
|
|
|
|
|
|
**Files modified:**
|
|
|
|
|
|
|
|
|
|
- includes/Product_Type.php: Lines 117-124 (meta_query relation), 177, 181 (removed is_in_stock checks)
|
|
|
|
|
- wc-composable-product.php: Version bump to 1.1.13
|
|
|
|
|
- CHANGELOG.md: v1.1.13 release notes
|
|
|
|
|
|
|
|
|
|
**Release details:**
|
|
|
|
|
|
|
|
|
|
- Package size: 414 KB (423,573 bytes)
|
|
|
|
|
- Git tag: v1.1.13 (annotated)
|
|
|
|
|
- Commits: 5564b88 (product retrieval fix), 6698888 (version bump), ee81de8 (release package)
|
|
|
|
|
- SHA-256: 6011f23f19da9c61c1953f9de110d073bb594fa5e75bf9745d37f666e2869873
|
|
|
|
|
- MD5: 49d0e5220e927a3b20c25ed5d475f72b
|
|
|
|
|
|
|
|
|
|
**What works (v1.1.13):**
|
|
|
|
|
|
|
|
|
|
Everything from v1.1.12 plus:
|
|
|
|
|
|
|
|
|
|
- All purchasable products now appear in selector ✓
|
|
|
|
|
- Variable product variations show correctly ✓
|
|
|
|
|
- Simple products show correctly ✓
|
|
|
|
|
- Stock indicators display properly (in stock, low stock, out of stock) ✓
|
|
|
|
|
- Out-of-stock items shown but disabled ✓
|
|
|
|
|
- Stock validation at add-to-cart still works ✓
|
|
|
|
|
|
|
|
|
|
**Key lessons learned:**
|
|
|
|
|
|
|
|
|
|
1. **Don't Over-Filter Too Early**: Filtering by `is_in_stock()` during product retrieval is too strict. Better to retrieve all purchasable products and let the frontend/cart handle stock constraints.
|
|
|
|
|
|
|
|
|
|
2. **Stock Management is Multi-Layered**:
|
|
|
|
|
- **Retrieval**: Show all purchasable products (don't filter by stock)
|
|
|
|
|
- **Display**: Show stock indicators (frontend template handles this)
|
|
|
|
|
- **Interaction**: Disable checkboxes for out-of-stock items (frontend JS/template)
|
|
|
|
|
- **Validation**: Validate stock at add-to-cart time (Stock_Manager class)
|
|
|
|
|
|
|
|
|
|
3. **WooCommerce Stock States**:
|
|
|
|
|
- `is_purchasable()` = Can this product be bought? (considers product status, price, etc.)
|
|
|
|
|
- `is_in_stock()` = Is this product in stock? (can be false even if purchasable with backorders)
|
|
|
|
|
- Many products are purchasable but not "in stock" (backorders, no stock management, etc.)
|
|
|
|
|
|
|
|
|
|
4. **Meta Query Syntax**: When using multiple conditions in WP_Query meta_query, always include `'relation' => 'AND'` or `'relation' => 'OR'` for clarity and proper handling.
|
|
|
|
|
|
|
|
|
|
5. **Debug by Elimination**:
|
|
|
|
|
- v1.1.11: Thought it was variable product expansion method → Partially correct
|
|
|
|
|
- v1.1.12: Thought it was variation ID retrieval → Fixed that issue
|
|
|
|
|
- v1.1.13: Realized it was stock filtering → Found the real culprit!
|
|
|
|
|
|
|
|
|
|
6. **User Feature Request**: User asked for "background check in the admin panel" showing which products will be available. This is a good future enhancement for debugging configuration issues.
|
|
|
|
|
|
|
|
|
|
**Remaining issues:**
|
|
|
|
|
|
|
|
|
|
User hasn't confirmed if v1.1.13 works yet. If products still don't show, next steps would be:
|
|
|
|
|
|
|
|
|
|
1. Add admin preview feature showing matched products
|
|
|
|
|
2. Debug the actual WP_Query being executed
|
|
|
|
|
3. Check if categories/tags/SKUs are being saved correctly
|
|
|
|
|
4. Verify tax_query construction is correct
|
|
|
|
|
5. Test with actual product data from the user's store
|
|
|
|
|
|
|
|
|
|
**Status:** v1.1.13 released and deployed, awaiting user confirmation
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
|
|
|
|
|
**For AI Assistants:**
|
|
|
|
|
|
|
|
|
|
When starting a new session on this project:
|
|
|
|
|
magdevandClaude Sonnet 4.5