magdev/wc-tier-and-package-prices
1
Fork 0
Code Issues Pull Requests Actions Releases 2 Activity

Release version 1.2.8 - Currency display and data deletion fixes

Browse Source 
Fixed two important bugs reported in v1.2.7:

Bug 1: Currency Symbol Missing in Admin Headers and Placeholders
- Table headers now show "Price (CURRENCY)" instead of just "Price"
- Input placeholders include currency symbol (e.g., "9.99 $")
- Better UX for multi-currency stores

Bug 2: Variation Pricing Data Not Deleted Properly (Critical)
- Empty pricing arrays were being saved instead of deleted
- Fixed save logic to check if arrays are empty after filtering
- Properly deletes post meta when all entries are removed
- Affects simple products, variable parents, and variations

Technical changes:
- Updated all table headers with currency symbol display
- Modified all render methods to pass currency_symbol to templates
- Updated Twig templates to use currency in placeholders
- Fixed save_tier_package_fields() and save_variation_pricing_fields()
- Added !empty() checks before update_post_meta() calls

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
Marco Grätsch
2025-12-30 01:23:55 +01:00
parent 348158050e
commit f26574aa4b
6 changed files with 80 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
includes/class-wc-tpp-product-meta.php
View File

@@ -55,7 +55,7 @@ if (!class_exists('WC_TPP_Product_Meta')) {
<thead>
<tr>
<th><?php _e('Min Quantity', 'wc-tier-package-prices'); ?></th>
<th><?php _e('Price', 'wc-tier-package-prices'); ?></th>
<th><?php printf(__('Price (%s)', 'wc-tier-package-prices'), get_woocommerce_currency_symbol()); ?></th>
<th><?php _e('Label (optional)', 'wc-tier-package-prices'); ?></th>
<th></th>
</tr>
@@ -85,7 +85,7 @@ if (!class_exists('WC_TPP_Product_Meta')) {
<thead>
<tr>
<th><?php _e('Quantity', 'wc-tier-package-prices'); ?></th>
<th><?php _e('Price', 'wc-tier-package-prices'); ?></th>
<th><?php printf(__('Price (%s)', 'wc-tier-package-prices'), get_woocommerce_currency_symbol()); ?></th>
<th><?php _e('Label (optional)', 'wc-tier-package-prices'); ?></th>
<th></th>
</tr>
@@ -149,7 +149,7 @@ if (!class_exists('WC_TPP_Product_Meta')) {
<thead>
<tr>
<th><?php _e('Min Quantity', 'wc-tier-package-prices'); ?></th>
<th><?php _e('Price', 'wc-tier-package-prices'); ?></th>
<th><?php printf(__('Price (%s)', 'wc-tier-package-prices'), get_woocommerce_currency_symbol()); ?></th>
<th><?php _e('Label (optional)', 'wc-tier-package-prices'); ?></th>
<th></th>
</tr>
@@ -195,7 +195,7 @@ if (!class_exists('WC_TPP_Product_Meta')) {
<thead>
<tr>
<th><?php _e('Quantity', 'wc-tier-package-prices'); ?></th>
<th><?php _e('Price', 'wc-tier-package-prices'); ?></th>
<th><?php printf(__('Price (%s)', 'wc-tier-package-prices'), get_woocommerce_currency_symbol()); ?></th>
<th><?php _e('Label (optional)', 'wc-tier-package-prices'); ?></th>
<th></th>
</tr>
@@ -241,14 +241,16 @@ if (!class_exists('WC_TPP_Product_Meta')) {
private function render_tier_row($index, $tier) {
WC_TPP_Template_Loader::get_instance()->display('admin/tier-row.twig', array(
'index' => $index,
'tier' => $tier
'tier' => $tier,
'currency_symbol' => get_woocommerce_currency_symbol()
));
}
private function render_package_row($index, $package) {
WC_TPP_Template_Loader::get_instance()->display('admin/package-row.twig', array(
'index' => $index,
'package' => $package
'package' => $package,
'currency_symbol' => get_woocommerce_currency_symbol()
));
}
@@ -285,7 +287,7 @@ if (!class_exists('WC_TPP_Product_Meta')) {
<thead>
<tr>
<th><?php _e('Min Quantity', 'wc-tier-package-prices'); ?></th>
<th><?php _e('Price', 'wc-tier-package-prices'); ?></th>
<th><?php printf(__('Price (%s)', 'wc-tier-package-prices'), get_woocommerce_currency_symbol()); ?></th>
<th><?php _e('Label (optional)', 'wc-tier-package-prices'); ?></th>
<th></th>
</tr>
@@ -308,7 +310,7 @@ if (!class_exists('WC_TPP_Product_Meta')) {
<thead>
<tr>
<th><?php _e('Quantity', 'wc-tier-package-prices'); ?></th>
<th><?php _e('Price', 'wc-tier-package-prices'); ?></th>
<th><?php printf(__('Price (%s)', 'wc-tier-package-prices'), get_woocommerce_currency_symbol()); ?></th>
<th><?php _e('Label (optional)', 'wc-tier-package-prices'); ?></th>
<th></th>
</tr>
@@ -363,7 +365,8 @@ if (!class_exists('WC_TPP_Product_Meta')) {
WC_TPP_Template_Loader::get_instance()->display('admin/tier-row.twig', array(
'index' => $index,
'tier' => $tier,
'field_prefix' => 'wc_tpp_tiers[' . $loop . ']'
'field_prefix' => 'wc_tpp_tiers[' . $loop . ']',
'currency_symbol' => get_woocommerce_currency_symbol()
));
}
@@ -378,7 +381,8 @@ if (!class_exists('WC_TPP_Product_Meta')) {
WC_TPP_Template_Loader::get_instance()->display('admin/package-row.twig', array(
'index' => $index,
'package' => $package,
'field_prefix' => 'wc_tpp_packages[' . $loop . ']'
'field_prefix' => 'wc_tpp_packages[' . $loop . ']',
'currency_symbol' => get_woocommerce_currency_symbol()
));
}
@@ -414,7 +418,12 @@ if (!class_exists('WC_TPP_Product_Meta')) {
usort($tiers, function($a, $b) {
return $a['min_qty'] - $b['min_qty'];
});
update_post_meta($post_id, '_wc_tpp_tiers', $tiers);
// Only save if we have valid tiers, otherwise delete
if (!empty($tiers)) {
update_post_meta($post_id, '_wc_tpp_tiers', $tiers);
} else {
delete_post_meta($post_id, '_wc_tpp_tiers');
}
} else {
delete_post_meta($post_id, '_wc_tpp_tiers');
}
@@ -435,7 +444,12 @@ if (!class_exists('WC_TPP_Product_Meta')) {
usort($packages, function($a, $b) {
return $a['qty'] - $b['qty'];
});
update_post_meta($post_id, '_wc_tpp_packages', $packages);
// Only save if we have valid packages, otherwise delete
if (!empty($packages)) {
update_post_meta($post_id, '_wc_tpp_packages', $packages);
} else {
delete_post_meta($post_id, '_wc_tpp_packages');
}
} else {
delete_post_meta($post_id, '_wc_tpp_packages');
}
@@ -473,7 +487,12 @@ if (!class_exists('WC_TPP_Product_Meta')) {
usort($tiers, function($a, $b) {
return $a['min_qty'] - $b['min_qty'];
});
update_post_meta($variation_id, '_wc_tpp_tiers', $tiers);
// Only save if we have valid tiers, otherwise delete
if (!empty($tiers)) {
update_post_meta($variation_id, '_wc_tpp_tiers', $tiers);
} else {
delete_post_meta($variation_id, '_wc_tpp_tiers');
}
} else {
delete_post_meta($variation_id, '_wc_tpp_tiers');
}
@@ -494,7 +513,12 @@ if (!class_exists('WC_TPP_Product_Meta')) {
usort($packages, function($a, $b) {
return $a['qty'] - $b['qty'];
});
update_post_meta($variation_id, '_wc_tpp_packages', $packages);
// Only save if we have valid packages, otherwise delete
if (!empty($packages)) {
update_post_meta($variation_id, '_wc_tpp_packages', $packages);
} else {
delete_post_meta($variation_id, '_wc_tpp_packages');
}
} else {
delete_post_meta($variation_id, '_wc_tpp_packages');
}