magdev/wc-tier-and-package-prices
1
Fork 0
Code Issues Pull Requests Actions Releases 2 Activity

2 Releases 39 Tags

  • v1.1.17 e46372da51
    Compare

    Release version 1.1.17 - Array duplicate prevention

    magdev released this 2025-12-22 22:05:11 +00:00 | 65 commits to main since this release

    Fixed persistent duplicate settings page by adding array-level duplicate
    detection in addition to singleton pattern from v1.1.16.

    Root Cause:

    • WooCommerce calls woocommerce_get_settings_pages filter multiple times
    • Even with singleton pattern, each filter call added settings instance to array
    • Singleton prevented multiple class instances but not multiple array entries

    Fixes:

    • Settings page rendering twice despite singleton pattern in v1.1.16
    • Filter adding same settings instance to array on repeated calls

    Changes:

    • Added duplicate detection loop in add_settings_page() before array append
    • Uses strict comparison (===) to check if instance already in array
    • Returns early if settings page already present, preventing duplicate

    Technical Details:

    • foreach loop iterates through existing $settings array
    • Compares each element against cached self::$settings_instance
    • Only appends to array if instance not found
    • Complements singleton pattern with array-level protection
    • Handles WooCommerce calling filter multiple times during page load

    Updated Files:

    • includes/class-wc-tpp-admin.php (added duplicate check in filter)
    • wc-tier-and-package-prices.php (version 1.1.17)
    • composer.json (version 1.1.17)
    • CHANGELOG.md (v1.1.17 section)

    🤖 Generated with Claude Code

    Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com

    Downloads