You've already forked wc-tier-and-package-prices
Fixed persistent duplicate settings page by adding array-level duplicate detection in addition to singleton pattern from v1.1.16. Root Cause: - WooCommerce calls woocommerce_get_settings_pages filter multiple times - Even with singleton pattern, each filter call added settings instance to array - Singleton prevented multiple class instances but not multiple array entries Fixes: - Settings page rendering twice despite singleton pattern in v1.1.16 - Filter adding same settings instance to array on repeated calls Changes: - Added duplicate detection loop in add_settings_page() before array append - Uses strict comparison (===) to check if instance already in array - Returns early if settings page already present, preventing duplicate Technical Details: - foreach loop iterates through existing $settings array - Compares each element against cached self::$settings_instance - Only appends to array if instance not found - Complements singleton pattern with array-level protection - Handles WooCommerce calling filter multiple times during page load Updated Files: - includes/class-wc-tpp-admin.php (added duplicate check in filter) - wc-tier-and-package-prices.php (version 1.1.17) - composer.json (version 1.1.17) - CHANGELOG.md (v1.1.17 section) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
57 lines
1.7 KiB
PHP
57 lines
1.7 KiB
PHP
<?php
|
|
/**
|
|
* Admin settings and configuration
|
|
*/
|
|
|
|
if (!defined('ABSPATH')) {
|
|
exit;
|
|
}
|
|
|
|
if (!class_exists('WC_TPP_Admin')) {
|
|
class WC_TPP_Admin {
|
|
|
|
private static $instance = null;
|
|
private static $settings_instance = null;
|
|
|
|
public static function get_instance() {
|
|
if (null === self::$instance) {
|
|
self::$instance = new self();
|
|
}
|
|
return self::$instance;
|
|
}
|
|
|
|
private function __construct() {
|
|
add_filter('woocommerce_get_settings_pages', array($this, 'add_settings_page'));
|
|
add_action('admin_enqueue_scripts', array($this, 'enqueue_admin_scripts'));
|
|
}
|
|
|
|
/**
|
|
* Add settings page to WooCommerce settings
|
|
*/
|
|
public function add_settings_page($settings) {
|
|
if (null === self::$settings_instance) {
|
|
self::$settings_instance = include WC_TPP_PLUGIN_DIR . 'includes/class-wc-tpp-settings.php';
|
|
}
|
|
|
|
// Check if our settings page is already in the array to prevent duplicates
|
|
foreach ($settings as $settings_page) {
|
|
if ($settings_page === self::$settings_instance) {
|
|
return $settings;
|
|
}
|
|
}
|
|
|
|
$settings[] = self::$settings_instance;
|
|
return $settings;
|
|
}
|
|
|
|
public function enqueue_admin_scripts($hook) {
|
|
if ('woocommerce_page_wc-settings' === $hook || 'post.php' === $hook || 'post-new.php' === $hook) {
|
|
wp_enqueue_style('wc-tpp-admin', WC_TPP_PLUGIN_URL . 'assets/css/admin.css', array(), WC_TPP_VERSION);
|
|
wp_enqueue_script('wc-tpp-admin', WC_TPP_PLUGIN_URL . 'assets/js/admin.js', array('jquery'), WC_TPP_VERSION, true);
|
|
}
|
|
}
|
|
}
|
|
|
|
WC_TPP_Admin::get_instance();
|
|
}
|