magdev
5e8db0980e
The Makefile's appimage target ran composer install with the path repo configured as `"symlink": true`. Composer created a symlink at vendor/php-qml/bridge → <BUNDLE_ABS>. rsync into the AppDir preserved the symlink, whose target path doesn't exist on the user's machine. At runtime: Caddy + frankenphp boot fine, /healthz returns 200 (no bundle services touched), but every API request fails with: Warning: include(.../symfony/vendor/composer/../php-qml/bridge/src/ BridgeBundle.php): Failed to open stream: No such file or directory …and the migrations step fails identically on first launch. COMPOSER_MIRROR_PATH_REPOS=1 is the documented env-var lever, but explicit `"symlink": true` in composer.json takes precedence over it (verified the env var alone leaves the symlink in place). Dropping the env var; instead, sed the symlink option to `false` in the staging composer.json, alongside the existing URL rewrite. Composer.json source-of-truth keeps `symlink: true` so dev-mode installs are still hot-reloadable against framework/php source. Only the staging copy used for AppImage assembly is mirrored. Verified locally: `vendor/php-qml/bridge` is now a real directory after composer install; `BridgeBundle.php` exists as a regular file. Note for follow-up (out of scope here): perfsmoke didn't catch this because /healthz doesn't touch any BridgeBundle services. Worth extending perfsmoke to also exercise an actual API endpoint so packaging regressions of this shape fail loudly in CI. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
83 lines
3.0 KiB
Makefile
83 lines
3.0 KiB
Makefile
# php-qml — Todo example app — Make targets.
|
|
|
|
.DEFAULT_GOAL := help
|
|
|
|
SYMFONY_DIR := symfony
|
|
QML_SRC_DIR := qml
|
|
BUILD_DIR := build/qml
|
|
QT_BIN := $(BUILD_DIR)/todo
|
|
|
|
.PHONY: help
|
|
help: ## Show available targets
|
|
@awk 'BEGIN {FS = ":.*?## "} /^[a-zA-Z_-]+:.*?## / {printf " %-12s %s\n", $$1, $$2}' $(MAKEFILE_LIST)
|
|
|
|
.PHONY: install
|
|
install: ## Install Composer dependencies for the Symfony app
|
|
cd $(SYMFONY_DIR) && composer install
|
|
|
|
.PHONY: build
|
|
build: ## Build the Qt host
|
|
cmake -S $(QML_SRC_DIR) -B $(BUILD_DIR) -DCMAKE_BUILD_TYPE=Debug
|
|
cmake --build $(BUILD_DIR) --parallel
|
|
|
|
.PHONY: dev
|
|
dev: build ## Run the todo app in dev mode (FrankenPHP --watch + Qt host)
|
|
./scripts/dev.sh
|
|
|
|
.PHONY: doctor
|
|
doctor: ## Run bridge:doctor inside the Symfony app
|
|
cd $(SYMFONY_DIR) && bin/console bridge:doctor
|
|
|
|
.PHONY: doctor-connect
|
|
doctor-connect: ## Run bridge:doctor with backend connectivity probe
|
|
cd $(SYMFONY_DIR) && bin/console bridge:doctor --connect
|
|
|
|
.PHONY: clean
|
|
clean: ## Remove build artefacts
|
|
rm -rf $(BUILD_DIR)
|
|
|
|
.PHONY: integration
|
|
integration: ## Run the bridge-integration test (FrankenPHP boot + HTTP/SSE round-trip + crash-recover)
|
|
./tests/integration.sh
|
|
|
|
.PHONY: perf
|
|
perf: ## Run the AppImage perf smoke test (PLAN.md §11 budgets)
|
|
./tests/perfsmoke.sh build/Todo-x86_64.AppImage
|
|
|
|
.PHONY: appimage
|
|
appimage: build ## Package as a single-file Linux AppImage at build/Todo-x86_64.AppImage
|
|
# Composer install --no-dev in a staging copy of symfony so the
|
|
# dev tree (with maker-bundle etc.) is left untouched.
|
|
rm -rf build/staging-symfony
|
|
rsync -a --delete \
|
|
--exclude='vendor/' \
|
|
--exclude='var/cache/' --exclude='var/log/' \
|
|
$(SYMFONY_DIR)/ build/staging-symfony/
|
|
# Rewrite the path repo to absolute so composer can find the bundle
|
|
# from the staging dir, AND flip symlink:true → false so composer copies
|
|
# the bundle into vendor/ — symlinks would survive the rsync into the
|
|
# AppDir but their targets wouldn't exist on the user's machine.
|
|
BUNDLE_ABS="$$(cd $(SYMFONY_DIR)/../../../framework/php && pwd)"; \
|
|
sed -i "s|\"../../../framework/php\"|\"$$BUNDLE_ABS\"|" build/staging-symfony/composer.json
|
|
sed -i 's|"symlink": true|"symlink": false|' build/staging-symfony/composer.json
|
|
rm -f build/staging-symfony/composer.lock
|
|
cd build/staging-symfony && composer install --no-dev --no-interaction --classmap-authoritative
|
|
../../packaging/linux/build-appimage.sh \
|
|
--app-name todo \
|
|
--host-binary $(QT_BIN) \
|
|
--symfony-dir build/staging-symfony \
|
|
--frankenphp $${FRANKENPHP:-frankenphp} \
|
|
--caddyfile Caddyfile \
|
|
--desktop packaging/todo.desktop \
|
|
--icon packaging/todo.png \
|
|
--output build/Todo-x86_64.AppImage \
|
|
$${APPIMAGE_UPDATE_INFO:+--update-info "$$APPIMAGE_UPDATE_INFO"}
|
|
@echo
|
|
@echo "AppImage built. Test with: ./build/Todo-x86_64.AppImage"
|
|
|
|
.PHONY: quality
|
|
quality: build ## Run PHPStan, php-cs-fixer (check), PHPUnit, qmllint, integration
|
|
cd ../../framework/php && composer quality
|
|
cmake --build $(BUILD_DIR) --target all_qmllint
|
|
./tests/integration.sh
|