magdev
0cca0785c0
Decouples /healthz from the publisher contract. v0.1.1 wired
HealthController to constructor-inject Publisher purely as a "is the
bundle resolvable" probe — that worked but cemented the publisher's
API as a readiness-test dependency, which was awkward once
PublisherInterface landed in v0.2.0 chunk 1.
Replace with BridgeBundleInfo: a tiny readonly VO carrying the
bundle's name + class FQCN. HealthController depends on this instead.
Same deep-load semantics (broken bundle → can't construct the VO →
500 on /healthz), no leaky publisher dep.
/healthz response shape:
- `bundle`: was `PhpQml\\Bridge\\Publisher`,
now `PhpQml\\Bridge\\BridgeBundle`
- `name`: new field, reports `php-qml/bridge`
bundled-supervisor.sh's grep updated to match the new canary value
plus an assertion that the new `name` field is present (catches a
botched BridgeBundleInfo wire-up that the bundle-class-name assertion
alone would miss).
Quality + maker snapshot + bundled-supervisor integration test all
pass locally.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
40 lines
1.2 KiB
PHP
40 lines
1.2 KiB
PHP
<?php
|
||
|
||
declare(strict_types=1);
|
||
|
||
namespace PhpQml\Bridge\Controller;
|
||
|
||
use PhpQml\Bridge\BridgeBundleInfo;
|
||
use Symfony\Component\HttpFoundation\JsonResponse;
|
||
use Symfony\Component\Routing\Attribute\Route;
|
||
|
||
/**
|
||
* Readiness probe used by the Qt host to detect when the backend is up.
|
||
* See PLAN.md §3 (*Startup*, step 4).
|
||
*
|
||
* `BridgeBundleInfo` is injected purely as a deep-load canary: if the
|
||
* bundle's autoload or container wiring is broken (e.g. a packaging build
|
||
* with a dangling vendor path-repo symlink), this controller can't even
|
||
* be constructed, so /healthz fails 500 instead of misleadingly returning
|
||
* 200 against a half-loaded bundle. Earlier (v0.1.1–v0.2.0) this canary
|
||
* was `PublisherInterface`; switching to a dedicated info VO decouples
|
||
* the readiness probe from the publisher's evolving contract.
|
||
*/
|
||
final class HealthController
|
||
{
|
||
public function __construct(
|
||
private readonly BridgeBundleInfo $info,
|
||
) {
|
||
}
|
||
|
||
#[Route('/healthz', name: 'php_qml_bridge_healthz', methods: ['GET'])]
|
||
public function __invoke(): JsonResponse
|
||
{
|
||
return new JsonResponse([
|
||
'status' => 'ok',
|
||
'bundle' => $this->info->bundle,
|
||
'name' => $this->info->name,
|
||
]);
|
||
}
|
||
}
|