magdev
ee68561bae
The previous fix (c78d471) moved the maker qml_path injection into
when@dev: but didn't repeat _defaults inside it. when@<env> opens a
fresh services block with no inheritance, so the explicit Maker
definitions lost autowire/autoconfigure — and with autoconfigure off,
maker-bundle's `maker.command` tag was never applied. Symptom in CI:
`make:bridge:resource` silently disappears from `bin/console list`
while `make:bridge:command` (registered by the glob, no override)
keeps working. Snapshot test failed with "Command 'make:bridge:resource'
is not defined".
Fix: add _defaults inside the when@dev block. Snapshot test passes
locally; prod cache:clear in --no-dev still compiles clean.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
44 lines
1.7 KiB
YAML
44 lines
1.7 KiB
YAML
services:
|
|
_defaults:
|
|
autowire: true
|
|
autoconfigure: true
|
|
|
|
PhpQml\Bridge\:
|
|
resource: '../src/'
|
|
exclude:
|
|
- '../src/BridgeBundle.php'
|
|
|
|
PhpQml\Bridge\SessionAuthenticator:
|
|
arguments:
|
|
$expectedToken: '%env(default::BRIDGE_TOKEN)%'
|
|
|
|
# Maker classes extend symfony/maker-bundle's AbstractMaker, which is a
|
|
# require-dev dependency. In `composer install --no-dev` builds (the
|
|
# staging-symfony tree the AppImage is assembled from) AbstractMaker is
|
|
# absent: PHP fails to autoload BridgeResourceMaker etc., so the glob
|
|
# above silently drops them — that's fine. But a top-level explicit
|
|
# `services.PhpQml\Bridge\Maker\BridgeResourceMaker:` block forces
|
|
# ResolveClassPass to load the class regardless of dev/prod, which then
|
|
# crashes the prod container compile. Scope the qml_path injection to
|
|
# `when@dev:` so prod builds never touch these definitions.
|
|
when@dev:
|
|
services:
|
|
# _defaults must be repeated here — `when@<env>` opens a fresh
|
|
# services block, so the top-level autowire/autoconfigure don't
|
|
# carry over. Without autoconfigure the explicit definitions
|
|
# below would lose maker-bundle's `maker.command` tag, and
|
|
# `make:bridge:resource` would silently disappear from the
|
|
# console while `make:bridge:command` (registered by the glob,
|
|
# no override) keeps working.
|
|
_defaults:
|
|
autowire: true
|
|
autoconfigure: true
|
|
|
|
PhpQml\Bridge\Maker\BridgeResourceMaker:
|
|
arguments:
|
|
$qmlPath: '%bridge.qml_path%'
|
|
|
|
PhpQml\Bridge\Maker\BridgeWindowMaker:
|
|
arguments:
|
|
$qmlPath: '%bridge.qml_path%'
|