4 Commits
1.0 ... 1.0.3

Author SHA1 Message Date
656deb2a26 test are working 2023-04-29 09:13:37 +02:00
ecb3a36f48 make this stuff run 2023-04-29 09:07:57 +02:00
8948ddf01b fixed parameter 2023-04-29 08:57:35 +02:00
cf753aaa20 fixed typos 2023-04-29 08:38:56 +02:00
4 changed files with 15 additions and 14 deletions

View File

@@ -21,9 +21,9 @@ final class Configuration implements ConfigurationInterface
->normalizeKeys(false)
->arrayPrototype()
->children()
->scalarNode('baseurl')
->scalarNode('url')
->isRequired()
->info('The base URL of your redmine instance')
->info('The URL of your Redmine instance')
->end()
->scalarNode('apikey')
->isRequired()

View File

@@ -22,7 +22,7 @@ final class MagdevRedmineExtension extends Extension
foreach ($config['connections'] as $name => $connection) {
$id = sprintf('magdev.redmine.%s', $name);
$container->register($id, NativeCurlClient::class)
->setArguments([$connection['baseurl'], $connection['apikey']]);
->setArguments([$connection['url'], $connection['apikey']]);
$container->registerAliasForArgument($id, NativeCurlClient::class, "{$name}Client");
if ($name === $config['default_connection']) {

View File

@@ -17,8 +17,8 @@ class ConfigurationTest extends TestCase
public function testConfig(array $configs): void
{
$config = (new Processor())->processConfiguration(new Configuration(), $configs);
$this->assertSame('foo', $config['connections']['default']['token']);
$this->assertSame('bar', $config['connections']['default']['baseurl']);
$this->assertSame('foo', $config['connections']['default']['apikey']);
$this->assertSame('bar', $config['connections']['default']['url']);
}
public function configsProvider(): iterable
@@ -28,8 +28,8 @@ class ConfigurationTest extends TestCase
'magdev_redmine' => [
'connections' => [
'default' => [
'token' => 'foo',
'baseurl' => 'bar'
'apikey' => 'foo',
'url' => 'bar'
],
],
],

View File

@@ -4,6 +4,7 @@ namespace Magdev\RedmineBundle\Tests\DependencyInjection;
use Magdev\RedmineBundle\DependencyInjection\MagdevRedmineExtension;
use PHPUnit\Framework\TestCase;
use Redmine\Client\NativeCurlClient;
use Symfony\Component\DependencyInjection\ContainerBuilder;
/**
@@ -18,8 +19,8 @@ class MagdevRedmineExtensionTest extends TestCase
(new MagdevRedmineExtension())->load([
'magdev_redmine' => [
'connections' => [
'primary' => ['baseurl' => 'http://foo1', 'token' => 'bar1'],
'secondary' => ['baseurl' => 'http://foo2', 'token' => 'bar2'],
'primary' => ['url' => 'http://foo1', 'apikey' => 'bar1'],
'secondary' => ['url' => 'http://foo2', 'apikey' => 'bar2'],
],
],
], $container);
@@ -27,11 +28,11 @@ class MagdevRedmineExtensionTest extends TestCase
$this->assertTrue($container->has('magdev.redmine.primary'));
$this->assertTrue($container->has('magdev.redmine.secondary'));
$this->assertTrue($container->hasAlias(Client::class));
$this->assertTrue($container->hasAlias(Client::class.' $primaryClient'));
$this->assertTrue($container->hasAlias(Client::class.' $secondaryClient'));
$this->assertTrue($container->hasAlias(NativeCurlClient::class));
$this->assertTrue($container->hasAlias(NativeCurlClient::class.' $primaryClient'));
$this->assertTrue($container->hasAlias(NativeCurlClient::class.' $secondaryClient'));
$this->assertInstanceOf(Client::class, $container->get('magdev.redmine.primary'));
$this->assertInstanceOf(Client::class, $container->get('magdev.redmine.secondary'));
$this->assertInstanceOf(NativeCurlClient::class, $container->get('magdev.redmine.primary'));
$this->assertInstanceOf(NativeCurlClient::class, $container->get('magdev.redmine.secondary'));
}
}