magdev/redmine-bundle
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Compare commits

base: magdev:1.0.1
Branches Tags
magdev:main
magdev:1.0.3 magdev:1.0.2 magdev:1.0.1 magdev:1.0
...
compare: magdev:1.0.3
Branches Tags
magdev:main
magdev:1.0.3 magdev:1.0.2 magdev:1.0.1 magdev:1.0

3 Commits
1.0.1 ... 1.0.3

Author SHA1 Message Date
magdev
656deb2a26 test are working 2023-04-29 09:13:37 +02:00
magdev
ecb3a36f48 make this stuff run 2023-04-29 09:07:57 +02:00
magdev
8948ddf01b fixed parameter 2023-04-29 08:57:35 +02:00
4 changed files with 14 additions and 13 deletions
Expand all files Collapse all files

2
src/DependencyInjection/Configuration.php
View File

@@ -14,7 +14,7 @@ final class Configuration implements ConfigurationInterface
{ {
$treeBuilder = new TreeBuilder('magdev_redmine'); $treeBuilder = new TreeBuilder('magdev_redmine');
$rootNode = $treeBuilder->getRootNode(); $rootNode = $treeBuilder->getRootNode();
$rootNode->fixXmlConfig('connections') $rootNode->fixXmlConfig('connection')
->children() ->children()
->arrayNode('connections') ->arrayNode('connections')
->useAttributeAsKey('name') ->useAttributeAsKey('name')

2
src/DependencyInjection/MagdevRedmineExtension.php
View File

@@ -22,7 +22,7 @@ final class MagdevRedmineExtension extends Extension
foreach ($config['connections'] as $name => $connection) { foreach ($config['connections'] as $name => $connection) {
$id = sprintf('magdev.redmine.%s', $name); $id = sprintf('magdev.redmine.%s', $name);
$container->register($id, NativeCurlClient::class) $container->register($id, NativeCurlClient::class)
->setArguments([$connection['baseurl'], $connection['apikey']]); ->setArguments([$connection['url'], $connection['apikey']]);
$container->registerAliasForArgument($id, NativeCurlClient::class, "{$name}Client"); $container->registerAliasForArgument($id, NativeCurlClient::class, "{$name}Client");
if ($name === $config['default_connection']) { if ($name === $config['default_connection']) {

8
tests/DependencyInjection/ConfigurationTest.php
View File

@@ -17,8 +17,8 @@ class ConfigurationTest extends TestCase
public function testConfig(array $configs): void public function testConfig(array $configs): void
{ {
$config = (new Processor())->processConfiguration(new Configuration(), $configs); $config = (new Processor())->processConfiguration(new Configuration(), $configs);
$this->assertSame('foo', $config['connections']['default']['token']); $this->assertSame('foo', $config['connections']['default']['apikey']);
$this->assertSame('bar', $config['connections']['default']['baseurl']); $this->assertSame('bar', $config['connections']['default']['url']);
} }
public function configsProvider(): iterable public function configsProvider(): iterable
@@ -28,8 +28,8 @@ class ConfigurationTest extends TestCase
'magdev_redmine' => [ 'magdev_redmine' => [
'connections' => [ 'connections' => [
'default' => [ 'default' => [
'token' => 'foo', 'apikey' => 'foo',
'baseurl' => 'bar' 'url' => 'bar'
], ],
], ],
], ],

15
tests/DependencyInjection/MagdevRedmineExtensionTest.php
View File

@@ -4,6 +4,7 @@ namespace Magdev\RedmineBundle\Tests\DependencyInjection;
use Magdev\RedmineBundle\DependencyInjection\MagdevRedmineExtension; use Magdev\RedmineBundle\DependencyInjection\MagdevRedmineExtension;
use PHPUnit\Framework\TestCase; use PHPUnit\Framework\TestCase;
use Redmine\Client\NativeCurlClient;
use Symfony\Component\DependencyInjection\ContainerBuilder; use Symfony\Component\DependencyInjection\ContainerBuilder;
/** /**
@@ -18,8 +19,8 @@ class MagdevRedmineExtensionTest extends TestCase
(new MagdevRedmineExtension())->load([ (new MagdevRedmineExtension())->load([
'magdev_redmine' => [ 'magdev_redmine' => [
'connections' => [ 'connections' => [
'primary' => ['baseurl' => 'http://foo1', 'token' => 'bar1'], 'primary' => ['url' => 'http://foo1', 'apikey' => 'bar1'],
'secondary' => ['baseurl' => 'http://foo2', 'token' => 'bar2'], 'secondary' => ['url' => 'http://foo2', 'apikey' => 'bar2'],
], ],
], ],
], $container); ], $container);
@@ -27,11 +28,11 @@ class MagdevRedmineExtensionTest extends TestCase
$this->assertTrue($container->has('magdev.redmine.primary')); $this->assertTrue($container->has('magdev.redmine.primary'));
$this->assertTrue($container->has('magdev.redmine.secondary')); $this->assertTrue($container->has('magdev.redmine.secondary'));
$this->assertTrue($container->hasAlias(Client::class)); $this->assertTrue($container->hasAlias(NativeCurlClient::class));
$this->assertTrue($container->hasAlias(Client::class.' $primaryClient')); $this->assertTrue($container->hasAlias(NativeCurlClient::class.' $primaryClient'));
$this->assertTrue($container->hasAlias(Client::class.' $secondaryClient')); $this->assertTrue($container->hasAlias(NativeCurlClient::class.' $secondaryClient'));
$this->assertInstanceOf(Client::class, $container->get('magdev.redmine.primary')); $this->assertInstanceOf(NativeCurlClient::class, $container->get('magdev.redmine.primary'));
$this->assertInstanceOf(Client::class, $container->get('magdev.redmine.secondary')); $this->assertInstanceOf(NativeCurlClient::class, $container->get('magdev.redmine.secondary'));
} }
} }