2 Commits

Author SHA1 Message Date
f1382490ec Fix Settings.php class loading timing issue (v1.1.2)
CRITICAL BUG FIX: v1.1.1 still had the same error!

Root cause analysis:
- v1.1.1 changed hook to woocommerce_init but error persisted
- Real issue: Settings.php was require_once'd in Plugin::includes()
- At that point, class extends WC_Settings_Page which doesn't exist yet
- Even woocommerce_init fires before WC_Settings_Page is loaded

Solution:
- Removed require_once from Plugin::includes() (line 93)
- Moved require_once to Plugin::add_settings_page() (line 196)
- Settings.php now loads on-demand via woocommerce_get_settings_pages filter
- This filter fires when WooCommerce has loaded all settings classes

Changes:
- includes/Plugin.php: Delayed Settings.php inclusion with explanatory comment
- wc-composable-product.php: Version bump to 1.1.2
- CHANGELOG.md: Documented fix and noted v1.1.1 was insufficient

This addresses the actual root cause that persisted through 3 versions.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2025-12-31 16:59:17 +01:00
f1b255a7f8 Add release package v1.1.1 and reorganize all releases
Release v1.1.1 - Critical bug fix:
- Fixed WC_Settings_Page class loading timing issue
- Changed initialization hook from woocommerce_loaded to woocommerce_init
- Ensures plugin activates correctly without fatal errors

Release organization:
- Moved v1.0.0 and v1.1.0 packages from root to releases/ directory
- Added v1.1.1 release package
- All releases now properly organized in releases/ subdirectory

v1.1.1 Package contents:
- Plugin source files (v1.1.1)
- Stock management integration (v1.1.0 feature)
- Complete vendor dependencies (Twig 3.0)
- Translation files for 6 locales
- Documentation and changelog

v1.1.1 Package details:
- Size: 375 KB
- SHA-256: 761eef69da910ecfdb20ceeed70b5d0381c7cab895e81a040d132cb0f88d749b

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2025-12-31 16:55:37 +01:00
6 changed files with 28 additions and 3 deletions

View File

@@ -5,6 +5,26 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
## [1.1.2] - 2024-12-31
### Fixed
- **CRITICAL**: Fixed persistent "Class WC_Settings_Page not found" error that continued in v1.1.1
- Root cause: Settings.php was being included too early (during plugin init) before WC_Settings_Page was loaded
- Solution: Delayed Settings.php inclusion until `woocommerce_get_settings_pages` filter when class is guaranteed to exist
### Technical
- Removed `require_once Settings.php` from `Plugin::includes()` (line 93)
- Added `require_once Settings.php` to `Plugin::add_settings_page()` (line 196)
- Settings file now loads on-demand when WooCommerce requests settings pages
- Previous hook change (woocommerce_init) was insufficient - class loading order was the real issue
### Notes
- v1.1.1 attempted to fix this with hook change but the error persisted
- This version addresses the actual root cause: premature class extension
## [1.1.1] - 2024-12-31
### Fixed

View File

@@ -90,7 +90,8 @@ class Plugin {
* Include required files
*/
private function includes() {
require_once WC_COMPOSABLE_PRODUCT_PATH . 'includes/Admin/Settings.php';
// Note: Settings.php is NOT included here because it extends WC_Settings_Page
// which isn't loaded until later. It's included in add_settings_page() instead.
require_once WC_COMPOSABLE_PRODUCT_PATH . 'includes/Admin/Product_Data.php';
require_once WC_COMPOSABLE_PRODUCT_PATH . 'includes/Product_Type.php';
require_once WC_COMPOSABLE_PRODUCT_PATH . 'includes/Stock_Manager.php';
@@ -191,6 +192,8 @@ class Plugin {
* @return array
*/
public function add_settings_page($settings) {
// Include Settings.php here, when WC_Settings_Page is guaranteed to be loaded
require_once WC_COMPOSABLE_PRODUCT_PATH . 'includes/Admin/Settings.php';
$settings[] = new Admin\Settings();
return $settings;
}

Binary file not shown.

View File

@@ -0,0 +1 @@
db09928aea6fffbf9c2e754d2264f2bc wc-composable-product-v1.1.1.zip

View File

@@ -0,0 +1 @@
761eef69da910ecfdb20ceeed70b5d0381c7cab895e81a040d132cb0f88d749b wc-composable-product-v1.1.1.zip

View File

@@ -3,7 +3,7 @@
* Plugin Name: WooCommerce Composable Products
* Plugin URI: https://github.com/magdev/wc-composable-product
* Description: Create composable products where customers select a limited number of items from a configurable set
* Version: 1.1.1
* Version: 1.1.2
* Author: Marco Graetsch
* Author URI: https://example.com
* License: GPL v3 or later
@@ -19,7 +19,7 @@
defined('ABSPATH') || exit;
// Define plugin constants
define('WC_COMPOSABLE_PRODUCT_VERSION', '1.1.1');
define('WC_COMPOSABLE_PRODUCT_VERSION', '1.1.2');
define('WC_COMPOSABLE_PRODUCT_FILE', __FILE__);
define('WC_COMPOSABLE_PRODUCT_PATH', plugin_dir_path(__FILE__));
define('WC_COMPOSABLE_PRODUCT_URL', plugin_dir_url(__FILE__));